Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Fixed aws-cli package name #80

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Fixed aws-cli package name #80

merged 1 commit into from
Aug 1, 2018

Conversation

palmlines
Copy link

Issue #79

  • Corrected package name for yum based distributions

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's strange our automated tests didn't catch this. I wonder if yum swallows an error (doesn't exit with a non-zero exit code) if some of the packages install correctly?

Could you run the automated tests? If they pass, this is good to merge!

@palmlines
Copy link
Author

I'm not quite sure how to do the automated tests, but I did find out about one of your other tools Terratest. I'll try to make it work. Would appreciate any advice or guides.

@brikis98
Copy link
Collaborator

brikis98 commented Aug 1, 2018

The tests are already in place. You just need to run them per these docs: https://github.com/hashicorp/terraform-aws-vault/tree/master/test

@palmlines
Copy link
Author

The test passed. Here's some of the output: https://gist.github.com/aanafcheh/1acce98ad693d02c3ba54fd5ffe1bf47

@brikis98
Copy link
Collaborator

brikis98 commented Aug 1, 2018

Wonderful, thank you!

@brikis98 brikis98 merged commit 7dc5f0f into hashicorp:master Aug 1, 2018
@brikis98
Copy link
Collaborator

brikis98 commented Aug 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants