This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Fixing tests using consul for dns #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump 'min_packer_version' -> 1.5.4 bump 'vault_version' -> 1.6.1 bump 'consul_version' -> 1.9.2
Adding 'service_registration' used when using a different storage backend like 's3' Updating systemd configuration based on this documentation https://learn.hashicorp.com/tutorials/vault/deployment-guide\#step-3-configure-systemd
Add a new test stage 'initialize_unseal' useful when running multiple times the 'validation' stage against the same cluster Add 'testVaultUsesConsulForDns' for all test cases
brikis98
reviewed
Jan 28, 2021
…ariable for the address of the consul agent to communicate with
brikis98
reviewed
Jan 29, 2021
…registration-address parameter
brikis98
approved these changes
Jan 29, 2021
brikis98
reviewed
Feb 10, 2021
brikis98
approved these changes
Feb 10, 2021
|
Tests passed! 🎉 So does this imply there's no actual bug with #228 / Ubuntu 18.04? That it was just that the service wasn't being registered? Or did we need newer Consul / Vault versions? |
Sorry, crazy week, just coming back to this now. That's great news, thank you! I'm going to merge and release this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize_unsealuseful when running multiple times thevalidationstage against the same clustertestVaultUsesConsulForDnsfor all test casesservice_registrationused when using a different storage backend likes3systemdconfiguration based on this configure-systemd documentationmin_packer_version->1.5.4vault_version->1.6.1consul_version->1.9.2