Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Terraform 0.12.x Upgrade #154

Merged
merged 28 commits into from
Jul 1, 2019
Merged

Terraform 0.12.x Upgrade #154

merged 28 commits into from
Jul 1, 2019

Conversation

mcalhoun
Copy link
Contributor

This PR makes all modules and examples compatible with Terraform 0.12.x.

Please note that this change is BACKWARDS INCOMPATIBLE and you MUST use Terraform 0.12.x and above with the code once this has been merged.

examples/vault-agent/main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
modules/private-tls-cert/main.tf Show resolved Hide resolved
modules/vault-cluster/main.tf Outdated Show resolved Hide resolved
propagate_at_launch = true
}

dynamic "tag" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to modify this to keep my module invocation the same. Does that seem correct?

Sample code:

cluster_extra_tags = [
    {
      key                 = "Environment"
      value               = var.environment
      propagate_at_launch = true
    }
  ]

My modification:

dynamic "tag" {
    for_each = [for s in var.cluster_extra_tags: {
      key                 = s.key
      value               = s.value
      propagate_at_launch = s.propagate_at_launch
    }]

    content {
      key                 = tag.value.key
      value               = tag.value.value
      propagate_at_launch = tag.value.propagate_at_launch
    }
  }

This was referenced Jul 1, 2019
@mcalhoun mcalhoun merged commit 088ccbb into master Jul 1, 2019
@mcalhoun mcalhoun deleted the feature/tf12-upgrade branch July 1, 2019 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants