Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aurora Cluster support #332

Merged
merged 30 commits into from
Jun 4, 2024
Merged

Aurora Cluster support #332

merged 30 commits into from
Jun 4, 2024

Conversation

sandrampeter
Copy link
Collaborator

@sandrampeter sandrampeter commented May 21, 2024 •
edited
Loading

Background

Adding example for Aurora RDS cluster with 1 Reader and 1 Writer. TFE will use the Cluster Endpoint for connecting to database. Increased the private subnet created by default to 3 as Aurora RDS cluster requires min 3 Azs for deployment.

JIRA

Test Configuration

Used Aurora PostgreSQL - version 16.2 (db.r5.xlarge)

@sandrampeter sandrampeter requested a review from a team as a code owner May 21, 2024 16:31
@sandrampeter sandrampeter changed the title Test aurora ha Test with AWS Aurora RDS May 21, 2024
@sandrampeter sandrampeter marked this pull request as draft May 21, 2024 18:13
@sandrampeter sandrampeter marked this pull request as ready for review May 21, 2024 18:25
@miguelhrocha miguelhrocha changed the title Test with AWS Aurora RDS Aurora Cluster support May 22, 2024
nikolasrieble
nikolasrieble reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! 💪 🚀
I have a few questions and suggestions and will also test the module myself.

In the meantime, I already wanted to share my feedback.
Please also update the main README to refer to this example in the examples section.

examples/standalone-rhel-aurora/locals.tf Outdated Show resolved Hide resolved
examples/standalone-rhel-aurora/outputs.tf Outdated Show resolved Hide resolved
examples/standalone-rhel-aurora/outputs.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/variables.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/variables.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/variables.tf Outdated Show resolved Hide resolved
modules/networking/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
miguelhrocha
miguelhrocha reviewed May 23, 2024
View reviewed changes
Copy link

@miguelhrocha miguelhrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two additional comments 👍🏼

modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
@sandrampeter sandrampeter marked this pull request as draft May 25, 2024 01:00
miguelhrocha
miguelhrocha reviewed May 27, 2024
View reviewed changes
Copy link

@miguelhrocha miguelhrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the iteration Sandra, have more comments 👍🏼

examples/standalone-aurora/variables.tf Outdated Show resolved Hide resolved
examples/standalone-aurora/variables.tf Show resolved Hide resolved
examples/standalone-aurora/main.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/variables.tf Show resolved Hide resolved
modules/aurora_database_cluster/outputs.tf Show resolved Hide resolved
modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
modules/aurora_database_cluster/main.tf Outdated Show resolved Hide resolved
@sandrampeter sandrampeter marked this pull request as ready for review May 27, 2024 17:53
nikolasrieble
nikolasrieble approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you Sandra.
Please make sure to once deploy this example and execute a few runs against it as a smoke test.

@sandrampeter sandrampeter merged commit 4e713e4 into main Jun 4, 2024
3 checks passed
@sandrampeter sandrampeter deleted the test_aurora_ha branch June 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelhrocha miguelhrocha miguelhrocha left review comments

@nikolasrieble nikolasrieble nikolasrieble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrampeter @miguelhrocha @nikolasrieble