Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add to no_proxy list #318

Merged
merged 3 commits into from
Nov 15, 2023
Merged

add to no_proxy list #318

merged 3 commits into from
Nov 15, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Nov 14, 2023 •
edited
Loading

Background

TF-8609

After the initial passing tests from the FDO addition, we have seen some more failures intermittently. This PR seeks to clear up those failures by fixing the no_proxy logic.

How Has This Been Tested

Here are the links to each of the passing tests, also shown below.

add to no_proxy list
86de2fb 
fix concat

no_proxy conditional

revert no_proxy for replicated

specify registry

add quay to no_proxy

fmt

remove quay from no_proxy

add disk_path to standalone vault

add disk_path to docker_compose
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test private-active-active destroy=false

✅ Terraform AWS Private Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test private-active-active-replicated destroy=false

✅ Terraform AWS Private Active/Active (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy private-active-active

✅ Terraform AWS Private Active/Active (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test active-active-rhel7-proxy

✅ Terraform AWS Active/Active RHEL7 Proxy (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test standalone-vault-replicated

✅ Terraform AWS Standalone Vault (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test public-active-active-replicated destroy=false

✅ Terraform AWS Public Active/Active (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test standalone-vault destroy=false

✅ Terraform AWS Standalone Vault (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy private-active-active-replicated

✅ Terraform AWS Private Active/Active (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test private-tcp-active-active destroy=false

✅ Terraform AWS Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test public-active-active

✅ Terraform AWS Public Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy public-active-active-replicated

✅ Terraform AWS Public Active/Active (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy standalone-vault

✅ Terraform AWS Standalone Vault (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy private-tcp-active-active

✅ Terraform AWS Private TCP Active/Active (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited
Loading

/test private-tcp-active-active-replicated destroy=false

✅ Terraform AWS Private TCP Active/Active (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy private-tcp-active-active-replicated

✅ Terraform AWS Private TCP Active/Active (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/test active-active-rhel7-proxy-replicated destroy=false

✅ Terraform AWS Active/Active RHEL7 Proxy (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023 •
edited by github-actions bot
Loading

/destroy active-active-rhel7-proxy-replicated

✅ Terraform AWS Active/Active RHEL7 Proxy (Replicated) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth marked this pull request as ready for review November 15, 2023 23:00
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner November 15, 2023 23:00
@anniehedgpeth anniehedgpeth merged commit 91d1a9a into main Nov 15, 2023
2 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/tf-8609-fdo-7 branch November 15, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoskolnik theoskolnik theoskolnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniehedgpeth @theoskolnik