-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF-10414] Replace EC2 AWS Launch Configuration for AWS Launch Templates #317
Conversation
…ec2-launch-templates
…ec2-launch-templates
/test standalone-vault destroy=true ✅ Terraform AWS Standalone Vault (FDO) - Test Report
|
/test public-active-active-replicated ✅ Terraform AWS Public Active/Active (Legacy) - Test Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Thanks for the improvement!
Background
Working on the AWS TFE FDO Standalone Mounted Disk, I've realized that to have a successful automated upgrade, we have to enable EBS volume creation from snapshot_ids.
While enabling that, I've found that the creation of a new EC2 launch configuration will be deprecated by EOY, in favor of EC2 Launch templates.
It adds the following arguments to the root module:
ebs_snapshot_id
argument, so mounted disk installations can be instantiated from an EBS snapshotec2_launch_template_tag_specifications
, so components created by the Launch configuration can be tagged accordingly.Relates OR Closes #316
How Has This Been Tested