Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-10414] Replace EC2 AWS Launch Configuration for AWS Launch Templates #317

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

miguelhrocha
Copy link

@miguelhrocha miguelhrocha commented Nov 14, 2023

Background

Working on the AWS TFE FDO Standalone Mounted Disk, I've realized that to have a successful automated upgrade, we have to enable EBS volume creation from snapshot_ids.

While enabling that, I've found that the creation of a new EC2 launch configuration will be deprecated by EOY, in favor of EC2 Launch templates.

It adds the following arguments to the root module:

  1. An optional ebs_snapshot_id argument, so mounted disk installations can be instantiated from an EBS snapshot
  2. An optional list of ec2_launch_template_tag_specifications, so components created by the Launch configuration can be tagged accordingly.

Relates OR Closes #316

How Has This Been Tested

  1. Via the standalone mounted disk module test
  2. Locally using a custom terraform module that uses the new arguments

@miguelhrocha miguelhrocha marked this pull request as ready for review November 14, 2023 12:51
@miguelhrocha miguelhrocha requested a review from a team as a code owner November 14, 2023 12:51
@miguelhrocha
Copy link
Author

miguelhrocha commented Nov 14, 2023

/test standalone-vault destroy=true

✅ Terraform AWS Standalone Vault (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor

anniehedgpeth commented Nov 14, 2023

/test public-active-active-replicated

✅ Terraform AWS Public Active/Active (Legacy) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

Base automatically changed from TF-10414-upgrade-to-aws-v5-provider to main November 14, 2023 16:05
Copy link
Contributor

@anniehedgpeth anniehedgpeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Thanks for the improvement!

@miguelhrocha miguelhrocha merged commit 96f8777 into main Nov 14, 2023
2 checks passed
@miguelhrocha miguelhrocha deleted the TF-10414-use-ec2-launch-templates branch November 14, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants