Be more permissive in allowed characters in a block label #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a block label would only be allowed to contain the set of characters in an Indentifier, however a block label string literal can contain pretty much any character. This commit updates the base HCL grammar to support both indentifiers and string literals in block labels and adds tests to ensure this behaviour works as expected.
|
Previously attempted in #46 |
radeksimko
approved these changes
Nov 15, 2023
radeksimko
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Previously a block label would only be allowed to contain the set of characters in an Identifier, however a block label string literal can contain pretty much any character. This commit updates the base HCL grammar to support both identifiers and string literals in block labels and adds tests to ensure this behaviour works as expected.
This PR also fixes up the grammar because it would match block labels that spanned lines, whereas the language spec doesn't allow that
This PR doesn't solve the issue of a brace or a double quote being in a string literal; e.g.
blockname "foo\{" {orblockname "foo\"bar" {would do weird highlighting. However, this PR is still much better at highlighting than the current code.