Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DEVELOPMENT.md with last release #43

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

sestegra
Copy link
Contributor

Since package.json file has been updated in previous release, the contribution documentation should be aligned with related updates.

Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
@radeksimko radeksimko added the documentation Improvements or additions to documentation label May 30, 2022
@jpogran
Copy link
Contributor

jpogran commented Jun 1, 2022

Thank you @sestegra for the help with the documentation! There are a couple of clarifying points here that you couldn't know about because we haven't circled back and updated things here.

I'll respond more inline, but in general we moved from updating each TextMate product JSON file individually to having YAML files with product specific information. This way we can build JSON with whatever overrides or specific rules needed, without having to maintain duplication across several files.

We chose to use Go to build out these files because it's closer to our toolchain in other parts of the company. I can understand if everyone does not want to install Go just to build the files, so I have it as a future task to add functionality here to help with that, but have not gotten to it yet.

If you don't mind, I'll add onto this PR with the steps needed as additional commits.

@sestegra
Copy link
Contributor Author

sestegra commented Jun 1, 2022

Feel free to add your commits to this PR.

@jpogran jpogran requested a review from radeksimko June 2, 2022 20:04
@jpogran jpogran added this to the 0.4.0 milestone Jun 2, 2022
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left some comments in-line, although most of them are related to the original content that you just moved around.

Co-authored-by: Radek Simko <radek.simko@gmail.com>
@radeksimko radeksimko merged commit 563d3f8 into hashicorp:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants