Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial jest unit testing and ncc preparation #1

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Initial jest unit testing and ncc preparation #1

merged 1 commit into from
Jun 29, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 29, 2021

The unit testing will run on pull requests and pushes. The ncc setup is borrowed from https://github.com/actions/javascript-action. action.js is a copy of the original index.js minus the automatic execution on loading.

The unit testing will run on pull requests and pushes. The `ncc` setup is borrowed from https://github.com/actions/javascript-action.
Copy link
Member

@milescrabill milescrabill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for adopting setup-hc-releases' ugly cousin :)

I repro'd the tests successfully and all passed, LGTM

@milescrabill milescrabill merged commit 55efb3b into hashicorp:main Jun 29, 2021
@bflad bflad deleted the td-github-actions-template branch June 29, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants