[WIP] remove "Replace" calls to make go get work on Packer

[SwampDragons]

Still needs work to fix the flock library

helps with #8846

[codecov-io]

Codecov Report

Merging #8909 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
packer/communicator.go	75.53% <0.00%> (-1.07%)	⬇️
packer/plugin/client.go	79.91% <0.00%> (-0.45%)	⬇️

[jhawk28]

looks like @azr just needs to update some errors to get his patch merged...

[azr]

Heh I hadn't realized the reviewed mesages on my PR, 🤦‍♂ I blame lack of sleep. I updated it now.

[SwampDragons]

Waiting on merge of gofrs/flock#43

[jhawk28]

The flock library doesn't have a go.mod file so I think you can just switch to the azr/flock repo. You can just update the package from the gofrs/flock to azr/flock here: https://github.com/hashicorp/packer/blob/master/common/filelock/filelock.go
and then update the go.mod from:

github.com/gofrs/flock v0.7.1

to

github.com/azr/flock v0.0.0-20190823144736-958d66434653

[azr]

Howdy ! I just bumped my flock PR ( link: gofrs/flock#43), there's also a WIP to make flock support public at the go level, I just bumped it too ( link: golang/go#33974) , but right now I think this PR will be blocked on those for a while. I already think that removing that apache thrift replace call is nice so I think we should merge this until one of the aforementioned issues gets bumped 🙂 . ( I edited the 'close #8846' to not close the issue ).

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.