(vsphere-iso) add ability to define multiple disks

[jhawk28]

Left the old fields so that this is a backwards compatible change. Will create a separate pull request to remove deprecated fields.

Closes #8749

[jhawk28]

@sylviamoss how do I kick off the build again? it looks like the one just took too long.

[nywilken]

Hi @jhawk28 this is off to a good start. Code wise it looks solid to me. I left a few comments around the documentation and the possibility of adding a new test case to the acceptance tests. I don't have much experience working with vsphere so I will defer to the approval from another maintainer who can test the changes.

[jhawk28]

@azr @sylviamoss @SwampDragons Should I merge or rebase off master to get the latest? It looks like the check-generate is failing.

[SwampDragons]

I normally rebase.

[SwampDragons]

I was able to stand up a vsphere cluster to test today. This looks good and works as expected. Thanks for this contribution, and thanks for your patience!!

[jetersen]

How is this intended to be written in HCL?

storage = [] is unsupported

packer -v
1.5.5

[jetersen]

Seems like a bug that disk_size is still required

So this how it would look

  disk_size = 32768
  disk_thin_provisioned = true

  storage {
    disk_size = 16384
    disk_thin_provisioned = true
  }
  storage {
    disk_size = 8192
    disk_thin_provisioned = true
  }

[jhawk28]

I'm assuming that your example parses without the disk_size. There is a disk_size check in prepare that should be updated:

	if c.DiskSize == 0 {
		errs = append(errs, fmt.Errorf("'disk_size' is required"))
	}

[jetersen]

the example parses but if I wanted to use only storage blocks than it would currently fail.

So this would fail because of the above code you pasted.

  storage {
    disk_size = 32768
    disk_thin_provisioned = true
  }
  storage {
    disk_size = 16384
    disk_thin_provisioned = true
  }
  storage {
    disk_size = 8192
    disk_thin_provisioned = true
  }

[jetersen]

The check should be updated to check if storage length is zero and DiskSize is zero :)

[jhawk28]

maybe like this: #8975

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.