Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad operator debug - add pprof duration / csi details #9346

Merged
merged 12 commits into from
Dec 1, 2020
Merged

nomad operator debug - add pprof duration / csi details #9346

merged 12 commits into from
Dec 1, 2020

Conversation

davemay99
Copy link
Contributor

@davemay99 davemay99 commented Nov 12, 2020 •
edited
Loading

From the helpText:

  -pprof-duration=<duration>
    Duration for pprof collection. Defaults to 1s.

@davemay99 davemay99 mentioned this pull request Nov 12, 2020
Closed
tgross
tgross requested changes Nov 13, 2020
View reviewed changes
command/operator_debug.go Outdated Show resolved Hide resolved
command/operator_debug.go Show resolved Hide resolved
@davemay99 davemay99 requested a review from tgross November 26, 2020 05:37
tgross
tgross reviewed Nov 30, 2020
View reviewed changes
command/operator_debug.go Outdated Show resolved Hide resolved
tgross
tgross reviewed Nov 30, 2020
View reviewed changes
command/operator_debug.go Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Nov 30, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nomad-storybook – ./ui/stories

🔍 Inspect: https://vercel.com/hashicorp/nomad-storybook/jvp79ofoq
✅ Preview: https://nomad-storybook-git-f-debug-pprof-csi.hashicorp.vercel.app

nomad-ui – ./ui

🔍 Inspect: https://vercel.com/hashicorp/nomad-ui/9lea7z3lp
✅ Preview: https://nomad-ui-git-f-debug-pprof-csi.hashicorp.vercel.app

@vercel vercel bot temporarily deployed to Preview – nomad November 30, 2020 17:21 Inactive
tgross
tgross reviewed Nov 30, 2020
View reviewed changes
command/operator_debug.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad November 30, 2020 21:49 Inactive
tgross
tgross approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@davemay99 davemay99 merged commit d8070e9 into master Dec 1, 2020
@davemay99 davemay99 deleted the f-debug-pprof-csi branch December 1, 2020 17:36
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nomad operator debug doesn't capture CSI volume claims
2 participants
@davemay99 @tgross