-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker runtimes #7932
Docker runtimes #7932
Conversation
This enables customers who want to use gvisor and have it configured on their clients.
…e runtime; add conflict test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few comments on the docs and wording of some of the messages.
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Other allow lists use allow_ prefix (e.g. allow_caps, allow_privileged).
81b36e7
to
44c93e3
Compare
Thanks @notnoop for following up, appreciate your openness. Excited to start using this |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Follow up to #7589 to add more tests and have an allow list for runtimes. The allowed list defaults to runc and nvidia.
Thanks @benbuzbee !