-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add page titles #5924
UI: Add page titles #5924
Conversation
I’ll stop here and make a list of proposed page titles.
“Job [Job name] - Nomad” seems preferable to “[Job name] - Jobs - Nomad”
This facilitates the possibility of page titles live-updating based on model characteristics.
ember-page-title directly supports passing a list of strings for concatenation.
This only happened because I had changed a title token in this file.
Hey @backspace I took a very quick look at this, I'm circle back tomorrow if nobody else has been here. I think my only thing from a user perspective would be.. What's your thoughts on putting the 'most important' thing at the front of the title, so the name of the job or whatever. Tabs are generally pretty small and when they get smaller, if I was to have multiple tabs open I would be able to distinguish between them easier if the name of the job was at the start instead of the word 'Job' Overall, this seems fine to me other than that, lemme know what you think on ^. Otherwise I'll circle back in the morning and give it a final look over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a little inconsistency between single and double quotes other than that LGTM!
Thanks to @johncowen for catching this! 😝
Visual Studio Code autocomplete!!!
I'm obviously late to the party, but I wanted to look at this too, and it looks nice! And of course there's an ember addon for title management ✨ |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This adds dynamic titles, as shown in this GIF: