fingerprinter keeps manual network config #5482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when operators need to log onto a machine where an alloc is running they will need to perform both an alloc/job status call and then a call to discover the node name from the node list. This updates both the job status and alloc status output to include the node name within the information to make operator use easier. Closes #2359 Cloess #1180
NodeResource.Networks uses the same function
09f1291 to
9683bf2
Compare
langmartin
commented
Mar 29, 2019
| return false | ||
| } | ||
|
|
||
| // r.Constraints == o.Constraints, order sensitive |
There was a problem hiding this comment.
should these two collections be compared as sets?
Co-Authored-By: langmartin <lang.martin@gmail.com>
|
@langmartin , the |
langmartin
added a commit
that referenced
this pull request
Apr 11, 2019
Revert "fingerprint Constraints and Affinities have Equals, as set" This reverts commit 596f16f. Revert "client tests assert the independent handling of interface and speed" This reverts commit 7857ac5. Revert "structs missed applying a style change from the review" This reverts commit 658916e. Revert "client, structs comments" This reverts commit be2838d. Revert "client fingerprint updateNetworks preserves the network configuration" This reverts commit fc309cb. Revert "client_test cleanup comments from review" This reverts commit bc0bf4e. Revert "client Networks Equals is set equality" This reverts commit f8d4323. Revert "struct cleanup indentation in RequestedDevice Equals" This reverts commit f474641. Revert "struct Equals checks for identity before value checking" This reverts commit 0767a46. Revert "fix client-test, avoid hardwired platform dependecy on lo0" This reverts commit e89dbb2. Revert "refactor error in client fingerprint to include the offending data" This reverts commit a7fed72. Revert "add client updateNodeResources to merge but preserve manual config" This reverts commit 84bd433. Revert "refactor struts.RequestedDevice to have its own Equals" This reverts commit 6897825. Revert "refactor structs.Resource.Networks to have its own Equals" This reverts commit 49e2e6c. Revert "refactor structs.Resource.Devices to have its own Equals" This reverts commit 4ede922. Revert "add COMPAT(0.10): Remove in 0.10 notes to impl for structs.Resources" This reverts commit 49fbaac. Revert "add structs.Resources Equals" This reverts commit 8528a2a. Revert "test that fingerprint resources are updated, net not clobbered" This reverts commit 8ee02dd.
langmartin
added a commit
that referenced
this pull request
Apr 11, 2019
…-config Revert accidental merge of pr #5482
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when updating the node data with fingerprint results, only merge in network data in the case that it was not manually specified in the configuration.
closes #2619