drivers/docker: rename logging type
to driver
#5372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker uses the term logging
driver
in its public documentations: indocker
daemon config[1],docker run
arguments [2] and in docker compose file[3].Interestingly, docker used
type
in its API [4] instead of everywhereelse.
It's unfortunate that Nomad used
type
modeling after the Docker APIrather than the user facing documents. Nomad using
type
feels verynon-user friendly as it's disconnected from how Docker markets the flag
and shows internal representation instead.
Here, we rectify the situation by introducing
driver
field andprefering it over
type
in logging.Doing it here in a backward compatible manner, and will update docs with
driver
field once 0.9 final ships.[1] https://docs.docker.com/config/containers/logging/configure/
[2] https://docs.docker.com/engine/reference/run/#logging-drivers---log-driver
[3] https://docs.docker.com/compose/compose-file/#logging
[4] https://docs.docker.com/engine/api/v1.39/#operation/ContainerCreate