consul: make failures_before_critical and success_before_passing work with group services #10764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with group services This PR fixes some job submission plumbing to make sure the Consul Check parameters - failure_before_critical - success_before_passing work with group-level services. They already work with task-level services.
isabeldepapel
approved these changes
Jun 15, 2021
| } | ||
| } | ||
| } | ||
| structsTask.Services = ApiServicesToStructs(apiTask.Services) |
tgross
approved these changes
Jun 15, 2021
| @@ -4,6 +4,7 @@ IMPROVEMENTS: | |||
| * cli: Added `-monitor` flag to `deployment status` command and automatically monitor deployments from `job run` command. [[GH-10661](https://github.com/hashicorp/nomad/pull/10661)] | |||
|
|
|||
| BUG FIXES: | |||
| * consul: Fixed a bug where consul check parameters missing in group services [[GH-10764](https://github.com/hashicorp/nomad/pull/10764)] | |||
There was a problem hiding this comment.
Let's add this to the 1.0.8 changelog as well (below)
notnoop
pushed a commit
that referenced
this pull request
Jun 22, 2021
consul: make failures_before_critical and success_before_passing work with group services
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some job submission plumbing to make sure the Consul check parameters
work with group-level services. They already work with task-level services. Took this opportunity to apply a
todorefactoring to re-use common API->structs services copying helper.Fixes #10678