Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: broken test TestTaskScriptCheck #10781

Closed
shoenig opened this issue Jun 18, 2021 · 2 comments · Fixed by #10784
Closed

e2e: broken test TestTaskScriptCheck #10781

shoenig opened this issue Jun 18, 2021 · 2 comments · Fixed by #10784
Assignees
Labels
theme/testing Test related issues type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Jun 18, 2021

Maybe we recently added this task service check task parameter validation and didn't check e2e tests?

=== RUN   TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck
    utils.go:93: 
        	Error Trace:	utils.go:93
        	            				wait.go:33
        	            				wait.go:19
        	            				utils.go:85
        	            				utils.go:107
        	            				script_checks.go:126
        	Error:      	Received unexpected error:
        	            	Unexpected response code: 500 (1 error occurred:
        	            		* Task group task_check validation failed: 1 error occurred:
        	            		* Task group service validation failed: 4 errors occurred:
        	            		* Check alive-1a is invalid: only task group service checks can be assigned tasks
        	            		* Check alive-2a is invalid: only task group service checks can be assigned tasks
        	            		* Check alive-2b is invalid: only task group service checks can be assigned tasks
        	            		* Check always-dead is invalid: only task group service checks can be assigned tasks
        	            	
        	            	
        	            	
        	            	
        	            	
        	            	)
        	Test:       	TestE2E/Consul/*consul.ScriptChecksE2ETest/TestTaskScriptCheck
@shoenig shoenig added type/bug theme/testing Test related issues labels Jun 18, 2021
@shoenig shoenig self-assigned this Jun 18, 2021
@shoenig
Copy link
Member Author

shoenig commented Jun 18, 2021

It was me. I totally broke this in https://github.com/hashicorp/nomad/pull/10764/files, where TaskName used to not be copied over, but now is because it's sharing code that wasn't exactly the same.

shoenig added a commit that referenced this issue Jun 18, 2021
This PR fixes a bug introduced in a refactoring

https://github.com/hashicorp/nomad/pull/10764/files#diff-56b3c82fcbc857f8fb93a903f1610f6e6859b3610a4eddf92bad9ea27fdc85ec

where task level service checks would inherent the task name
field, when they shouldn't.

Fixes #10781
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/testing Test related issues type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant