Add Logout Method #214
Merged
Add Logout Method #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache file path will also be needed to clear the login cache entry to enable logout.
Without this function it was not possible anymore to implement a logout functionality.
The method can be used to clear the cached login token and thus to logout a CLI session.
This should make it easier to find the tests that belong to a specific type.
Calling ClearLoginCache() and c.Token() subsequently will have the same effect and it does not require a specific HCP configuration just to perform a login.
To provide guidance for users of the SDK on how they should implement login / logout functionality.
This should make it easier for a human to read the file if necessary.
It is not necessary to persist `"login": null` or `"service-principals": {}`.
3fac332 to
8ab425a
Compare
dadgar
approved these changes
Nov 6, 2023
evanphx
approved these changes
Nov 6, 2023
biazmoreira
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This implements a
hcpConfig.Logout()method. Logout could previously be implemented by invalidating the cache. This now isn't possible anymore as the cache is not exported.This change further removes the recently introduced
forceLoginconfiguration value, as force login can easily be implemented by invokinghcpConfig.Logout()followed byhcpConfig.Token()without the need for a special configuration setting.👍 Definition of Done