Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCE-273: user session refresh #129

Merged
merged 36 commits into from
Nov 17, 2022
Merged

HCE-273: user session refresh #129

merged 36 commits into from
Nov 17, 2022

Conversation

bcmdarroch
Copy link
Contributor

🛠️ Description

This PR adds session management for any user logging in via browser, instead of client credentials. Sessions will last a day before requiring re-authentication.

👍 Definition of Done

  • A user can log in via browser once and remain logged in for 24 hours.
  • Tests added?
  • Docs updated?

@bcmdarroch bcmdarroch requested a review from a team November 8, 2022 22:23
JolisaBrownHashiCorp and others added 26 commits November 8, 2022 17:25
@JolisaBrownHashiCorp @bcmdarroch
add session_expiry logic
981c19d
@JolisaBrownHashiCorp @bcmdarroch
testing sessionExpiry path
f805a48
@JolisaBrownHashiCorp @bcmdarroch
table driven testing write test refactor
6494668
@JolisaBrownHashiCorp @bcmdarroch
refactor to implement ducktyping/interfaces
254bd5f
@JolisaBrownHashiCorp @bcmdarroch
interface changes
7a33f39
@bcmdarroch
WIP refactor
3845d3d 
Co-authored-by: Brenna Hewer-Darroch <bcmdarroch@users.noreply.github.com>
@JolisaBrownHashiCorp @bcmdarroch
read tests refactor
0d8a94c
@JolisaBrownHashiCorp @bcmdarroch
update browser login conditional
e3fd7b1
@bcmdarroch
add error handling
5ef1869
@JolisaBrownHashiCorp @bcmdarroch
fix typo read tests, refactor duplicate test case
cc68afb
@bcmdarroch
add test case for Read, missing session expiry
89c96ca 
also add comment about expiry errors
@bcmdarroch
extract session managing code into GetToken
586969c 
browser implementation
@bcmdarroch
rename Getter -> Session
2c188f4
@bcmdarroch
rename browser.go to user.go
16ba3b7 
more specific, meaningful name
@bcmdarroch
add config session unit test
1b5a093
@JolisaBrownHashiCorp @bcmdarroch
include new option
a5c6f14
@bcmdarroch
add unit test for GetToken
383a3a4
@JolisaBrownHashiCorp @bcmdarroch
unit testing with mock
5a8704f
@bcmdarroch
change session variable g -> s
4b0af09
@bcmdarroch
go mod tidy
617c3d9 
updating testify to get ErrorContains
@bcmdarroch
fix cache test issues
9485cb0
@bcmdarroch
add mock browser to test session checking logic
5b4e67c
@bcmdarroch
add jwt format check
7f3bc6c
@bcmdarroch
correct token to jwt
bcb2eea
@bcmdarroch
linting
db8cb0c
@bcmdarroch
skip test until follow-up fix
c09cf40
@bcmdarroch bcmdarroch force-pushed the hce-273-session-refresh branch from 2855fcb to c09cf40 Compare November 8, 2022 22:26
bcmdarroch
bcmdarroch commented Nov 9, 2022
View reviewed changes
bcmdarroch
bcmdarroch commented Nov 9, 2022
View reviewed changes
bcmdarroch
bcmdarroch commented Nov 10, 2022
View reviewed changes
bcmdarroch
bcmdarroch commented Nov 10, 2022
View reviewed changes
bcmdarroch
bcmdarroch commented Nov 10, 2022
View reviewed changes
@itsjaspermilan itsjaspermilan merged commit b0919f9 into main Nov 17, 2022
@itsjaspermilan itsjaspermilan deleted the hce-273-session-refresh branch November 17, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JolisaBrownHashiCorp JolisaBrownHashiCorp JolisaBrownHashiCorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcmdarroch @JolisaBrownHashiCorp @itsjaspermilan