Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Make modifiers plural in LabelSchema #110

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Mar 22, 2022

This is to enable hashicorp/terraform-schema#96


The PR introduces a number of changes:

@radeksimko radeksimko force-pushed the make-label-modifiers-plural branch from dd1b4b6 to 293f6f8 Compare March 22, 2022 11:39
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for splitting this into four easy to follow commits

@radeksimko radeksimko merged commit 521a8c0 into main Mar 22, 2022
@radeksimko radeksimko deleted the make-label-modifiers-plural branch March 22, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants