schema: Make modifiers plural in LabelSchema #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable hashicorp/terraform-schema#96
The PR introduces a number of changes:
SemanticTokenModifier
inLabelSchema
becomes plural, allowing assignment of more than 1 modifier via schemaSemanticTokenModifier
inBlockSchema
becomes plural, allowing assignment of more than 1 modifier via schema (this actually remains unused downstream in Declare all token modifiers explicitly for labels and attributes terraform-schema#100 but it's mostly just to align the API and make it more flexible 🤷🏻SemanticTokenModifiers
toAttrSchema
such that we can use it downstream to report dependent attributes and later for adding any more modifiers per Provide token modifiers for attributes terraform-ls#835