schema/attribute: introduce explicit IsOptional field #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to differentiate between fields which are computed-only (IsComputed: true, IsOptional: false) and computed + optional (IsComputed: true, IsOptional: true). Technically we could assume IsOptional: true when IsComputed: false, but that would likely make a future serialization story more complex and introduce potential confusion for callers where they may just read raw struct field, instead of going through some functions which set the defaults.
radeksimko
added a commit
to hashicorp/terraform-schema
that referenced
this pull request
Nov 9, 2020
radeksimko
added a commit
to hashicorp/terraform-schema
that referenced
this pull request
Nov 9, 2020
radeksimko
added a commit
to hashicorp/terraform-schema
that referenced
this pull request
Nov 9, 2020
appilon
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to differentiate between fields which are
computed-only (IsComputed: true, IsOptional: false)
and computed + optional (IsComputed: true, IsOptional: true).
Technically we could assume IsOptional: true when IsComputed: false,
but that would likely make a future serialization story more complex
and introduce potential confusion for callers where they may just read
raw struct field, instead of going through some functions
which set the defaults.