add links for dependecy key attribute expressions

hashicorp · Apr 19, 2022 · f72f9ef · f72f9ef
1 parent f24c834
commit f72f9ef
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/decoder/links.go b/decoder/links.go
@@ -44,16 +44,24 @@ func (d *PathDecoder) linksInBody(body *hclsyntax.Body, bodySchema *schema.BodyS
 		if block.Body != nil {
 			depSchema, dk, ok := NewBlockSchema(blockSchema).DependentBodySchema(block.AsHCLBlock())
 			if ok && depSchema.DocsLink != nil {
+				link := depSchema.DocsLink
+				u, err := d.docsURL(link.URL, "documentLink")
+				if err != nil {
+					continue
+				}
 				for _, labelDep := range dk.Labels {
-					link := depSchema.DocsLink
-					u, err := d.docsURL(link.URL, "documentLink")
-					if err == nil {
-						links = append(links, lang.Link{
-							URI:     u.String(),
-							Tooltip: link.Tooltip,
-							Range:   block.LabelRanges[labelDep.Index],
-						})
-					}
+					links = append(links, lang.Link{
+						URI:     u.String(),
+						Tooltip: link.Tooltip,
+						Range:   block.LabelRanges[labelDep.Index],
+					})
+				}
+				for _, attrDep := range dk.Attributes {
+					links = append(links, lang.Link{
+						URI:     u.String(),
+						Tooltip: link.Tooltip,
+						Range:   block.Body.Attributes[attrDep.Name].Expr.Range(),
+					})
 				}
 			}
 		}

diff --git a/decoder/links_test.go b/decoder/links_test.go
@@ -117,6 +117,7 @@ func TestLinksInFile_json(t *testing.T) {
 		},
 	})
 
+	// We never want to provide links in JSON configs
 	_, err := d.LinksInFile("test.tf.json")
 	unknownFormatErr := &UnknownFileFormatError{}
 	if !errors.As(err, &unknownFormatErr) {