-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Allow "LicenseDir" field for non-enterprise usage #214
[feat] Allow "LicenseDir" field for non-enterprise usage #214
Conversation
… path copies the file as "LICENSE.txt" regardless of if the src file is "LICENSE" or "LICENSE.txt"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good aside from my inline comments!
Also thanks for handling the situation with enterprise versions. I did not realise we would have when writing the linked issue.
This does imply breaking change but it seems worth making, we just need to call it out in the Changelog (which I can do once it's merged).
2. Remove test
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor concerns remaining as per my comments inline. Once those are addressed I'm more than happy to merge this.
What
High-level overview
Introduces
LicenseDir
field into the following:build.GitRevision
checkpoint.LatestVersion
releases.ExactVersion
releases.LatestVersion
versions.InstallationOptions
Removes
LicenseDir
field from:EnterpriseOptions
build.GitRevision
pathsToRemove
to match other uses.checkpoint.LatestVersion
DownloadAndUnpack
callcheckpoint
doesn't support Enterprise, and before this PR, it was assumed that only Enterprise versions would contain a License.versions.InstallationOptions
InstallationOptions
- same struct that containsInstallDir
.Why
Closes #213