Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files are not closed on windows #232

Closed
MarcosDY opened this issue Dec 21, 2022 · 2 comments · Fixed by #241
Closed

Files are not closed on windows #232

MarcosDY opened this issue Dec 21, 2022 · 2 comments · Fixed by #241

Comments

@MarcosDY
Copy link

MarcosDY commented Dec 21, 2022 •
edited
Loading

additionalNotesAboutCommand is opening a file using elf, macho and pe to extract information,
but those files are never closed.
This can cause issues when another process is trying to open them again or try to remove.
@amartinezfayo amartinezfayo mentioned this issue Dec 22, 2022
Closed
@drakkan drakkan mentioned this issue Mar 4, 2023
Merged
@amartinezfayo amartinezfayo mentioned this issue May 31, 2023
Merged
@rturner3
Copy link

Is there any upcoming planned release with the fix for this issue? This is preventing github.com/spiffe/spire from being able to update to the latest version of github.com/hashicorp/vault/sdk.

This was referenced Jun 1, 2023
Open
Merged
@evan2645
Copy link
Contributor

evan2645 commented Jun 2, 2023

@rturner3 v1.4.10 has been released which includes this fix, thank you @fairclothjm for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

additional notes: ensure to close files drakkan/go-plugin
3 participants
@evan2645 @MarcosDY @rturner3