Split req and client #230
Merged
Split req and client #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2020
notnoop
approved these changes
Feb 4, 2020
as this one is mainly used internally.
49dd117 to
a8c9a40
Compare
|
Thanks for reviewing @notnoop 🙏 !! Pong 🏓 ! |
notnoop
reviewed
Feb 4, 2020
| checksumFileURL, err := urlhelper.Parse(checksumFile) | ||
| // ChecksumFromFile will only return checksums for files that match | ||
| // checksummedURL, which is the object being checksummed. | ||
| func (c *Client) ChecksumFromFile(ctx context.Context, checksumURL, checksummedURL string) (*FileChecksum, error) { |
There was a problem hiding this comment.
actually, one more nitpick - now that we pass u.Path, checksummedURL should be checksummedPath?
There was a problem hiding this comment.
Ah I didn't see this one sorry, you are correct. I will make a new PR changing this.
There was a problem hiding this comment.
Ah I pushed it directly to v2 🙂
This was referenced Mar 5, 2020
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #176.
This branch split request arguments from the client into a new request struct.
This is the groundwork to allow the go-getter to use file inplace or tell what operation happened.