add TestDecompressorPermissions, test it with tar & zip

decompress_tar_test.go

@@ -1,6 +1,8 @@
 package getter
 
 import (
+	"io/ioutil"
+	"os"
 	"path/filepath"
 	"testing"
 	"time"
@@ -41,3 +43,50 @@ func TestTar(t *testing.T) {
 
 	TestDecompressor(t, new(tarDecompressor), cases)
 }
+
+// testDecompressPermissions decompresses a directory and checks the permissions of the expanded files
+func testDecompressorPermissions(t *testing.T, d Decompressor, input string, expected map[string]int, umask os.FileMode) {
+	td, err := ioutil.TempDir("", "getter")
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	// Destination is always joining result so that we have a new path
+	dst := filepath.Join(td, "subdir", "result")
+
+	err = d.Decompress(dst, input, true, umask)
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	defer os.RemoveAll(dst)
+
+	for name, mode := range expected {
+		fi, err := os.Stat(filepath.Join(dst, name))
+		if err != nil {
+			t.Fatalf("err: %s", err)
+		}
+
+		real := fi.Mode()
+		if real != os.FileMode(mode) {
+			t.Fatalf("err: %s expected mode %o got %o", name, mode, real)
+		}
+	}
+}
+
+func TestDecompressTarPermissions(t *testing.T) {
+	d := new(tarDecompressor)
+	input := "./test-fixtures/decompress-tar/permissions.tar"
+	expected := map[string]int{
+		"directory/public":  0666,
+		"directory/private": 0600,
+		"directory/zero":    0,
+		"directory/exec":    0755,
+		"directory/setuid":  040000755,
+	}
+
+	testDecompressorPermissions(t, d, input, expected, os.FileMode(0))
+
+	expected["directory/setuid"] = 0755
+	testDecompressorPermissions(t, d, input, expected, os.FileMode(060000000))
+}

decompress_zip_test.go

@@ -1,6 +1,7 @@
 package getter
 
 import (
+	"os"
 	"path/filepath"
 	"testing"
 )
@@ -96,3 +97,21 @@ func TestZipDecompressor(t *testing.T) {
 
 	TestDecompressor(t, new(ZipDecompressor), cases)
 }
+
+func TestDecompressZipPermissions(t *testing.T) {
+	d := new(ZipDecompressor)
+	input := "./test-fixtures/decompress-zip/permissions.zip"
+	expected := map[string]int{
+		"directory/public":  0666,
+		"directory/private": 0600,
+		// zip won't add this file, since it can't be read
+		// "directory/zero":    0,
+		"directory/exec":   0755,
+		"directory/setuid": 040000755,
+	}
+
+	testDecompressorPermissions(t, d, input, expected, os.FileMode(0))
+
+	expected["directory/setuid"] = 0755
+	testDecompressorPermissions(t, d, input, expected, os.FileMode(060000000))
+}