[QT-555] Fix panic when passing an invalid scenario filter #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a panic when we tried to execute scenario sub-commands against a scenario that has no variants but we've included invalid matrix filters. Signed-off-by: Ryan Cragun <me@ryan.ec>
joshbrand
approved these changes
May 5, 2023
| @@ -99,11 +99,6 @@ func (e Element) Equal(other Element) bool { | |||
| return true | |||
| } | |||
|
|
|||
| // NewElementFromProto creates a new Element from a proto filter element | |||
| func NewElementFromProto(p *pb.Scenario_Filter_Element) Element { | |||
| @@ -10,7 +10,7 @@ import ( | |||
|
|
|||
| // Test_ScenarioFilter_WithScenarioFilterFromScenarioRef tests filtering a | |||
| // scenario that was created from a scenario reference. | |||
| func Test_ScenarioFilter_WithScenarioFilterFromScenarioRe(t *testing.T) { | |||
| func Test_ScenarioFilter_WithScenarioFilterFromScenarioRef(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a panic when we tried to execute scenario sub-commands against a scenario that has no variants but we've included invalid matrix filters.
Checklist