Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT-529] Always generate a Terraform configuration files #81

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

ryancragun
Copy link
Collaborator

Enos scenarios always override the CLI configuration file to ensure that we don't accidentally inherit global configuration. Previously we relied on simply setting the environment variable and geneating actual contents only if they were set in the scenario. Terraform 1.4.2 changed the behavior to warn if the environment variable was set to a non-existent file. Now we always create the file even if it's blank.

How to read this pull request

You may provide an optional explanation of the best way a review might
approach the changes that are being proposed in this pull request.

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

Enos scenarios always override the CLI configuration file to ensure that
we don't accidentally inherit global configuration. Previously we relied
on simply setting the environment variable and geneating actual contents
only if they were set in the scenario. Terraform 1.4.2 changed the
behavior to warn if the environment variable was set to a non-existent
file. Now we always create the file even if it's blank.

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun requested a review from a team as a code owner March 22, 2023 22:32
@ryancragun ryancragun added the changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes. label Mar 22, 2023
Copy link
Contributor

@joshbrand joshbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🐱

@ryancragun ryancragun merged commit 1c09455 into main Mar 22, 2023
@ryancragun ryancragun deleted the qt-529 branch March 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants