Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT-352] Always output exec information #76

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[QT-352] Always output exec information #76

merged 1 commit into from
Oct 24, 2022

Conversation

ryancragun
Copy link
Collaborator

When executing commands that output information we should always display it in the operation summary. This change ensures the output and exec scenario sub-commands are always displayed in the operation summary in the human readable mode.

  • Always display the output of exec sub-commands in the operation status.
  • Always configure the exec operation runner with a reference to the scenario Terraform module.
  • Bump version
  • Use the diagnostics helper function to determine the status for all scenario sub-command operations.
  • Update acceptance test runners to use different ports to allow for better parallel acceptance test execution.

Signed-off-by: Ryan Cragun me@ryan.ec

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

When executing commands that output information we should always display
it in the operation summary. This change ensures the `output` and `exec`
scenario sub-commands are always displayed in the operation summary in
the human readable mode.

* Always display the output of exec sub-commands in the operation
  status.
* Always configure the exec operation runner with a reference to the
  scenario Terraform module.
* Bump version
* Use the diagnostics helper function to determine the status for all
  scenario sub-command operations.
* Update acceptance test runners to use different ports to allow for
  better parallel acceptance test execution.

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun requested a review from a team as a code owner October 24, 2022 18:24
@ryancragun ryancragun added the changelog/feat New feature or enhancement. Will be included in "New Features" category in release notes. label Oct 24, 2022
Copy link
Contributor

@mikebaum mikebaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ryancragun ryancragun merged commit a4ec981 into main Oct 24, 2022
@ryancragun ryancragun deleted the qt-352 branch October 24, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/feat New feature or enhancement. Will be included in "New Features" category in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants