Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform_cli: support path and env and in terraform_cli blocks #152

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ryancragun
Copy link
Collaborator

@ryancragun ryancragun commented Jul 3, 2024

At some point during the serial to multiplex rewrite of Enos, we stopped
respecting the special path and env attributes in terraform_cli
blocks.

I discovered this when attempting to test an older version of Terraform
with enos by setting the path and it was still resolving the latest
version which it found via the PATH.

This resolves that by configuring the Terraform executor in the
workspace with any special terraform_cli variables that have been set
in the flight plan.

  • Configure the Terraform executor with the scenario "terraform_cli"
    attributes if necessary
  • Regenerate protobuf with latest generator
  • Update Go modules
  • Bump version

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

@ryancragun ryancragun added the changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes. label Jul 3, 2024
@ryancragun ryancragun requested a review from a team as a code owner July 3, 2024 20:28
At some point during the serial to multiplex rewrite of Enos, we stopped
respecting the special `path` and `env` attributes in `terraform_cli`
blocks.

I discovered this when attempting to test an older version of Terraform
with `enos` by setting the `path` and it was still resolving the latest
version which it found via the `PATH`.

This resolves that by configuring the Terraform executor in the
workspace with any special `terraform_cli` variables that have been set
in the flight plan.

* Configure the Terraform executor with the scenario "terraform_cli"
  attributes if necessary
* Regenerate protobuf with latest generator
* Update Go modules
* Bump version

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun force-pushed the ryan/fix-terraform-cli-path branch from 8096df9 to f0c86a8 Compare July 11, 2024 16:57
@ryancragun ryancragun merged commit 0243a3e into main Aug 1, 2024
5 checks passed
@ryancragun ryancragun deleted the ryan/fix-terraform-cli-path branch August 1, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants