Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-28010] fix(funcs): fix relative paths in file() #145

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ryancragun
Copy link
Collaborator

The recently added file() function supports relative paths but they’ll always be relative to the working dir that exec’s enos. This is usually fine unless enos is invoked with --chdir, in which case we need funcs that support relative paths to be relative to the --chdir working dir.

  • Make file() support the --chdir base path when given a base path
  • Bump the version
  • Add tests for funcs that support relative paths
  • Remove test data that wasn't being used

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

@ryancragun ryancragun added the changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes. label Jun 10, 2024
@ryancragun ryancragun requested a review from a team as a code owner June 10, 2024 21:23
The recently added `file()` function supports relative paths but they’ll
always be relative to the working dir that exec’s enos. This is usually
fine unless enos is invoked with `--chdir`, in which case we need funcs
that support relative paths to be relative to the `--chdir` working dir.

* Make `file()` support the `--chdir` base path when given a base path
* Bump the version
* Add tests for funcs that support relative paths
* Remove test data that wasn't being used

Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun merged commit 3ab1184 into main Jun 10, 2024
5 checks passed
@ryancragun ryancragun deleted the ryan/vault-28010 branch June 10, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant