Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix various linters and a panic with malformed variable bodies #123

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

ryancragun
Copy link
Collaborator

This started as a fix for the a nil panic if we run into syntax issues when decoding vars files.

It ended with pleasing new linters that came with the latest version of golangci-lint.

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
@ryancragun ryancragun added the changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes. label Feb 27, 2024
@ryancragun ryancragun requested a review from a team as a code owner February 27, 2024 22:54
@ryancragun ryancragun merged commit 8dc4c76 into main Feb 28, 2024
6 checks passed
@ryancragun ryancragun deleted the ryan/fix-panic branch February 28, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/bug Fix for something that wasn't working. Will be included in "Bug Fixes" category in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants