-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace details/summary in website side nav with button and list #2242
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first review. A few things that would need addressing.
website/app/components/doc/table-of-contents/collapsible-item.js
Outdated
Show resolved
Hide resolved
website/app/components/doc/table-of-contents/collapsible-item.hbs
Outdated
Show resolved
Hide resolved
website/app/components/doc/table-of-contents/collapsible-item.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug has been bothering me for so long. TY for fixing it!
📌 Summary
This PR replaces the
<detail>
and<summary>
elements that handle the collapsible sections in the website side navigation with<button>
s that show and hide a<ul>
.REMAINING WORK:
.doc-table-of-contents__summary
to be.doc-table-of-contents__button
now that it is no longer on a summary element?🛠️ Detailed description
To do this, I added a new component
<Doc::TableOfContents::CollapsibleItem>
.Other changes I made for this work were:
📸 Screenshots
Nothing visually changed, but here is the markup before:
and here is the markup after:
🔗 External links
Jira ticket: HDS-1308
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.