Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: expose the list of supported envoy versions on /v1/agent/self #8545

Merged
merged 2 commits into from
Aug 26, 2020
Merged

agent: expose the list of supported envoy versions on /v1/agent/self #8545

merged 2 commits into from
Aug 26, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 21, 2020

The xDS api exposed on a Consul agent's gRPC port can only successfully emit xDS configuration for a supported range of envoy versions documented here: https://www.consul.io/docs/connect/proxies/envoy#supported-versions

For systems that may wish to automatically launch the latest supported envoy version (like Nomad) this support matrix currently has to be copied from markdown into code in that system.

This PR exposes consul's own internal knowledge of the last 4 supported envoy versions on the /v1/agent/self endpoint like this:

$ curl -sL 'localhost:8500/v1/agent/self' | jq .xDS
{
  "SupportedProxies": {
    "envoy": [
      "1.15.0",
      "1.14.4",
      "1.13.4",
      "1.12.6"
    ]
  }
}

@rboyer rboyer added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies backport/1.7 theme/consul-nomad Consul & Nomad shared usability labels Aug 21, 2020
@rboyer rboyer requested review from shoenig and a team August 21, 2020 15:18
@rboyer rboyer self-assigned this Aug 21, 2020
shoenig
shoenig approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM && thanks!

@rboyer rboyer merged commit fead4fc into master Aug 26, 2020
@rboyer rboyer deleted the agent-self-envoy-support branch August 26, 2020 15:04
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit fead4fc onto release/1.8.x failed! Build Log

@rboyer rboyer mentioned this pull request Aug 26, 2020
Merged
rboyer added a commit that referenced this pull request Aug 26, 2020
@rboyer
agent: expose the list of supported envoy versions on /v1/agent/self (#…
1e89ad7 
…8545)
rboyer added a commit that referenced this pull request Aug 26, 2020
@rboyer
agent: expose the list of supported envoy versions on /v1/agent/self (#…
33a55c6 
…8545)
@rboyer rboyer mentioned this pull request Aug 26, 2020
Merged
shoenig added a commit to hashicorp/nomad that referenced this pull request Sep 16, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
8f899ed 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the API component is not available, Nomad will fallback to
the old version of Envoy supported by old versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior.

Addresses #8585 #7665
shoenig added a commit to hashicorp/nomad that referenced this pull request Sep 22, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
cc34fff 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
@shoenig shoenig mentioned this pull request Sep 22, 2020
Merged
shoenig added a commit to hashicorp/nomad that referenced this pull request Oct 13, 2020
@shoenig
consul/connect: dynamically select envoy sidecar at runtime
bdeb73c 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses #8585 #7665
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@shoenig @fredrikhgrelland
consul/connect: dynamically select envoy sidecar at runtime
5b51397 
As newer versions of Consul are released, the minimum version of Envoy
it supports as a sidecar proxy also gets bumped. Starting with the upcoming
Consul v1.9.X series, Envoy v1.11.X will no longer be supported. Current
versions of Nomad hardcode a version of Envoy v1.11.2 to be used as the
default implementation of Connect sidecar proxy.

This PR introduces a change such that each Nomad Client will query its
local Consul for a list of Envoy proxies that it supports (hashicorp/consul#8545)
and then launch the Connect sidecar proxy task using the latest supported version
of Envoy. If the `SupportedProxies` API component is not available from
Consul, Nomad will fallback to the old version of Envoy supported by old
versions of Consul.

Setting the meta configuration option `meta.connect.sidecar_image` or
setting the `connect.sidecar_task` stanza will take precedence as is
the current behavior for sidecar proxies.

Setting the meta configuration option `meta.connect.gateway_image`
will take precedence as is the current behavior for connect gateways.

`meta.connect.sidecar_image` and `meta.connect.gateway_image` may make
use of the special `${NOMAD_envoy_version}` variable interpolation, which
resolves to the newest version of Envoy supported by the Consul agent.

Addresses hashicorp#8585 hashicorp#7665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

@shoenig shoenig shoenig approved these changes

Assignees

@rboyer rboyer

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-nomad Consul & Nomad shared usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rboyer @hashicorp-ci @shoenig @freddygv