ui: Use top-level 'named index files' instead of in folder index files #8274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍒✅ Cherry pick of commit 7edb3ec onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 9, 2020
#8274) * Remove unused phrase-editor CSS * Move index.scss files to top-level named files to make them more obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our
folder-name/index.scssfiles to top level 'named index files':With this change it feels a lot easier to find the ‘index’ files at the top level rather than digging into the folders and trying to spot the index file.
It's even harder if you don’t know the codebase and you don’t even know we rollup/import the folder contents up in an index file within the folder itself.
Hopefully this make things more obvious:
Slight side note, we found some dead code (the old phrase editor component) so we removed this whilst we were here.