ui: Per Service Intentions Tab #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 8, 2020 10:52
We are still loading the intentions themselves in the parent Route for the moment
Once we have an intention form underneath the service/intention tab this will no longer be needed
kaxcode
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Add model layer support for filtering intentions by service * Add Route, Controller and template for services.show.intentions tab We are still loading the intentions themselves in the parent Route for the moment * Load the intentions in in the parent route for the moment * Temporarily add support for returning to history -1 Once we have an intention form underneath the service/intention tab this will no longer be needed * Add the new tab and enable blocking queries for it * Add some further acceptance testing around intention listings
johncowen
added a commit
that referenced
this pull request
Apr 30, 2020
* Add model layer support for filtering intentions by service * Add Route, Controller and template for services.show.intentions tab We are still loading the intentions themselves in the parent Route for the moment * Load the intentions in in the parent route for the moment * Temporarily add support for returning to history -1 Once we have an intention form underneath the service/intention tab this will no longer be needed * Add the new tab and enable blocking queries for it * Add some further acceptance testing around intention listings
kaxcode
pushed a commit
that referenced
this pull request
May 11, 2020
* Add model layer support for filtering intentions by service * Add Route, Controller and template for services.show.intentions tab We are still loading the intentions themselves in the parent Route for the moment * Load the intentions in in the parent route for the moment * Temporarily add support for returning to history -1 Once we have an intention form underneath the service/intention tab this will no longer be needed * Add the new tab and enable blocking queries for it * Add some further acceptance testing around intention listings
johncowen
added a commit
that referenced
this pull request
May 12, 2020
* Add model layer support for filtering intentions by service * Add Route, Controller and template for services.show.intentions tab We are still loading the intentions themselves in the parent Route for the moment * Load the intentions in in the parent route for the moment * Temporarily add support for returning to history -1 Once we have an intention form underneath the service/intention tab this will no longer be needed * Add the new tab and enable blocking queries for it * Add some further acceptance testing around intention listings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tab under a Service detail page to show the intentions relevant to that service.
Notes:
History
We went with a temporary fake history addition here so that the intentions edit page returns to where-ever you came from, and shows where you come from in our breadcrumblike-submenu. Future work should add an intention form directly into the same tab listing, so this is likely to be a temporary measure until that work is complete.
Component Page Objects
Now that we are moving all our components to nested folders, and adding more components as we go, it would be nice to add page objects to each of those folders, instead of split off in the tests folder.
If you try this, then the page-object is complied into the production source code and it seems to be less that trivial to avoid this (we tried using
ember-cli-funnelbut that seems to not work for excluding file any more).We left some comments around this to look into at a future date.