docs: add docs for kv_max_value_size #7405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
673b974 to
157bea1
Compare
Apart from the added docs, the error messages are similar now and are pointing to the corresponding options. Fixes #6708.
157bea1 to
a3be482
Compare
schristoff
approved these changes
Mar 6, 2020
schristoff
reviewed
Mar 6, 2020
mkeeler
reviewed
Mar 6, 2020
| @@ -1449,6 +1449,17 @@ Valid time units are 'ns', 'us' (or 'µs'), 'ms', 's', 'm', 'h'." | |||
| single RPC call to a Consul server. See | |||
| https://en.wikipedia.org/wiki/Token_bucket for more details about how | |||
| token bucket rate limiters operate. | |||
| * <a name="kv_max_value_size"></a><a href="#kv_max_value_size"> | |||
| `kv_max_value_size`</a> - Configures the maximum number of | |||
There was a problem hiding this comment.
Suggested change
| `kv_max_value_size`</a> - Configures the maximum number of | |
| `kv_max_value_size`</a> - **(Advanced)** Configures the maximum number of |
There was a problem hiding this comment.
Taken from the other advanced settings.
freddygv
pushed a commit
that referenced
this pull request
Mar 12, 2020
Apart from the added docs, the error messages are similar now and are pointing to the corresponding options. Fixes #6708.
findkim
pushed a commit
that referenced
this pull request
Mar 17, 2020
Apart from the added docs, the error messages are similar now and are pointing to the corresponding options. Fixes #6708.
|
Hey @i0rek, thanks for adding documentation about the option. Just curious about this:
Could you elaborate? Does increasing or decreasing the limit have a negative impact? What is considered improper? |
alvin-huang
pushed a commit
to alvin-huang/consul
that referenced
this pull request
May 6, 2020
Apart from the added docs, the error messages are similar now and are pointing to the corresponding options. Fixes hashicorp#6708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the added docs, the error messages are similar now and are pointing to the corresponding options.
Fixes #6708.