add envoy version 1.12.2 and 1.13.0 to the matrix #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7848e29 to
66cd15d
Compare
jippi
reviewed
Feb 10, 2020
banks
reviewed
Feb 10, 2020
pearkes
reviewed
Feb 10, 2020
| @@ -36,7 +36,8 @@ compatible Envoy versions. | |||
|
|
|||
| | Consul Version | Compatible Envoy Versions | | |||
| |---|---| | |||
| | 1.5.2 and higher | 1.11.1 1.10.0, 1.9.1, 1.8.0† | | |||
| | 1.7.0 and higher | 1.12.2, 1.11.2, 1.10.0, 1.9.1 | | |||
There was a problem hiding this comment.
Just a note that maybe we should clarify in the changelog for 1.7.0 that we now require Envoy > 1.9.1.
|
Go tests that failed are flaky (one autopilot one that @s-christoff has a fix in the works for, and the infamous SecondaryCA_IntermediateRefresh test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and stop officially supporting 1.9.1 and 1.8.0. This PR introduces a new flag to
consul connect:-envoy-versionwhich should be given the envoy version that the configuration is being bootstrapped for. This is required to run1.10.0because it doesn't understand the bootstrap configuration the later versions get.Problems:
1.10.0doesn't supportlayered_runtime:error initializing configuration '/workdir/primary/envoy/s1-bootstrap.json': Unable to parse JSON as proto (INVALID_ARGUMENT:layered_runtime: Cannot find field.): {1.13.0http case failsTodo: