-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give feedback to CLI user on forceleave command if node does not exist #6841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks good @adams-sarah, thanks for taking care of this. I added a comment and a request inline.
Lastly, some tests need to be updated since the CI test failures are related to these changes. A few tests didn't create a node before issuing a ForceLeave request, so now they're getting an error because of it.
Codecov Report
@@ Coverage Diff @@
## master #6841 +/- ##
==========================================
+ Coverage 65.79% 65.82% +0.02%
==========================================
Files 435 435
Lines 52405 52412 +7
==========================================
+ Hits 34482 34501 +19
+ Misses 13787 13782 -5
+ Partials 4136 4129 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! LGTM
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
No description provided.