Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure auto_encrypt has private key type and bits #6392

Merged
merged 1 commit into from
Aug 27, 2019
Merged

make sure auto_encrypt has private key type and bits #6392

merged 1 commit into from
Aug 27, 2019

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Aug 26, 2019 •
edited
Loading

PrivateKeyType and PrivateKeyBits is empty when loading c.config.CAConfig.GetCommonConfig() which causes an error. This PR makes sure it has at least the defaults and also adds a test that would've caught this problem.

Fixes #6391

@hanshasselberg hanshasselberg requested a review from a team August 26, 2019 11:12
@hanshasselberg
Copy link
Member Author

Test failures seem unrelated.

freddygv
freddygv approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hanshasselberg hanshasselberg added this to the 1.6.1 milestone Aug 27, 2019
@hanshasselberg hanshasselberg merged commit d051342 into master Aug 27, 2019
@hanshasselberg hanshasselberg deleted the auto_encrypt_private_key_fix branch August 27, 2019 12:38
@tradel tradel mentioned this pull request Aug 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

Error starting agent: AutoEncrypt failed: unknown private key type requested: on autoencrypt enabled client
2 participants
@hanshasselberg @freddygv