ui: Change layout styling for healthcheck-output, add CheckID #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
approved these changes
Jul 23, 2019
| } | ||
| %healthcheck-output.passing { | ||
| %healthcheck-output { | ||
| /* TODO: this should be a frame-gray */ |
There was a problem hiding this comment.
Hey @backspace !
Yeah still relevant, I don't know when we'll get round to doing it though. The gray combination here should eventually be made into a %frame-gray-000 similar to all my other colors, just its really difficult to make a good set of grays! I left it in there as we should definitely give it a shot at some point.
|
Thankyou!! 🙏 |
johncowen
added a commit
that referenced
this pull request
Aug 22, 2019
johncowen
added a commit
that referenced
this pull request
Aug 29, 2019
johncowen
added a commit
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the styling slightly for our healthcheck outputs. Functionally this also adds the CheckID information to the output panels.
Before:
After:
Designs show the copy buttons as a new gray color. We haven't done this here as yet and we'd rather do (and check) that as part of a re-styling of copy buttons across the UI.
cc @ChipV223