ui: Adds ability to search by policy, role or service ident names #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DingoEatingFuzz
suggested changes
May 9, 2019
|
Hey @DingoEatingFuzz Thanks for taking a look! I added a ton of new unit and acceptance tests around this. Originally we were trying to get the feature shipped in 1.5, hence we skipped these to revisit after release as at the time as we were fairly confident this feature was good. I may have gone a bit overboard with tests here, but definitely worthwhile getting some incase we regress anywhere. There are a few other PRs that made it but I skipped tests with as the confidence was reasonably high and we wanted to ship the feature, so hopefully you'll see a few other test heavy PRs coming for regressions sake before we move forwards with other things. Thanks, John |
added 6 commits
June 4, 2019 13:58
570043a to
409ceb9
Compare
DingoEatingFuzz
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to search by Role or ServiceIdentity name to the Token listings page, and the ability to search by Policy or ServiceIdentity name to the Role listings page.
(You could already search by policies on the token listing page)
This functionality will potentially be replaced by a new search UI in the future, which will make this far nicer for users to use.