Add support for alternate DNS domains #4526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for alternate DNS domains for internal consul resolution. SOA records and reverse lookups will still use the original domain.
|
Hi @akshayganeshen are you interested in making further edits and completing this PR? If so we will review it and send you some comments. |
|
Hey @freddygv, yes, definitely! I didn't spend too long on it, so I'm sure there are issues with it. All feedback is greatly appreciated! For now I'll rebase. |
|
Had to recreate the PR since my fork was deleted. See #5940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate DNS domains are supplied with the
-alt-domainflag oralt_domainsconfiguration parameter.The DNS resolver will attempt to parse and match each domain during resolution.
See #4165 for use-case.