Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed log level for retryable error Scenarios #22141

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

anandmukul93
Copy link
Contributor

1- xDS DeltaDiscoveryRequest context cancelled set to INFO on stream cancelled as it is retrieable
2- subscription failed logging on ACL change is set to INFO as is also retriable

Description

For an enterprise ask as referred in an internal JIRA ticket.

Testing & Reproduction steps

Testing reproduction done -
1 - created a new build with consul changes in local and container image with binary.
2 - used the new image to start consul server with dev-binary inside a kind cluster
3 - start a service and shut down a service to see the above logs.
4 - Since only ACL change occurred and context cancelled are being handled currently with the corresponding understanding that they are retriable, others are cases will still be in error level .
5- As you can see in the last three lines - to get INFO level lines. run a consul server and try to shut down a service
6 - check that these log lines appear as INFO level

2025-02-07T13:33:08.027Z [INFO] agent.envoy: Error receiving new DeltaDiscoveryRequest; closing request channel: error="rpc error: code = Canceled desc = context canceled"

2025-02-07T13:33:14.026Z [INFO] agent.proxycfg.server-data-sources: subscribe call failed: err="subscription closed by server, ACL change occurred" failure_count=1 key=mesh topic=MeshConfig

2025-02-07T13:33:14.026Z [INFO] agent.proxycfg.server-data-sources: subscribe call failed: err="subscription closed by server, ACL change occurred" failure_count=1 topic=JWTProvider wildcard_subject=true

Links

Related past PR - #20876

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

    1- xDS DeltaDiscoveryRequest context cancelled set to INFO on stream cancelled as it is retrieable
    2- subscription failed logging on ACL change is set to INFO as is also retriable
@anandmukul93 anandmukul93 requested a review from a team as a code owner February 12, 2025 12:55
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Feb 12, 2025
Copy link
Member

@sreeram77 sreeram77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sreeram77 sreeram77 requested a review from a team February 12, 2025 13:24
@anandmukul93 anandmukul93 merged commit e82b93b into main Feb 12, 2025
94 checks passed
@anandmukul93 anandmukul93 deleted the change-log-level branch February 12, 2025 13:28
@anandmukul93 anandmukul93 added backport/1.20 Changes are backported to 1.20 backport/ent/1.19 Changes are backported to 1.19 ent and removed pr/no-backport labels Feb 12, 2025
@anandmukul93 anandmukul93 added pr/no-backport and removed backport/1.20 Changes are backported to 1.20 backport/ent/1.19 Changes are backported to 1.19 ent labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants