NET-5912/service-defaults protocol validation #21593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0751dc1 to
1c92192
Compare
1c92192 to
1b68af1
Compare
caf53d4 to
dac29ef
Compare
dac29ef to
239db97
Compare
dhiaayachi
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Hey @JadhavPoonam
I left a question before I can approve this change. That said, I find it really funny that all our test cases test for the actual field being with an unsupported value udp 😆
239db97 to
48e3b08
Compare
221ae7a to
76fe462
Compare
76fe462 to
6d73e47
Compare
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
* fix: add validation for protocol field on service-defaults config entry * test: update test cases with correct protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
protocolfield forservice-defaults. With this change, the CLI and HTTP API only allows values listed in the documentation.Testing & Reproduction steps
v1/config) and CLIconfig writeLinks
Ticket: https://hashicorp.atlassian.net/browse/NET-5912
PR Checklist