-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check error in TestDNSCycleRecursorCheckAllFail before asserting response to stop panic in CI. #20231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onse to stop panic in CI.
jmurret
added
pr/no-changelog
PR does not need a corresponding .changelog entry
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
pr/no-backport
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
backport/1.17
This release series is no longer active on CE. Use backport/ent/1.17.
labels
Jan 17, 2024
hashi-derek
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…onse to stop panic in CI. (#20231)
jmurret
added a commit
that referenced
this pull request
Jan 17, 2024
…serting response to stop panic in CI. into release/1.17.x (#20235) * no-op commit due to failed cherry-picking * check error in TestDNSCycleRecursorCheckAllFail before asserting response to stop panic in CI. (#20231) --------- Co-authored-by: temp <temp@hashicorp.com> Co-authored-by: John Murret <john.murret@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
backport/1.17
This release series is no longer active on CE. Use backport/ent/1.17.
pr/no-backport
pr/no-changelog
PR does not need a corresponding .changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is likely a flake in here as well, but this panic causes other tests not to run and stops gotestum from re-running tests with
rerun aborted because previous run had a suspected panic and some test may not have run.
. This PR is just meant to stabilize the panic and hopefully fixing the flake will be easier with an error message.the original panic error is below when the test tries to check
in.Rcode
but has not checked for an error first:Description
Testing & Reproduction steps
Links
PR Checklist