Backport of Various race condition and test fixes. into release/1.17.x #20216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-team-consul-core-pr-approver
approved these changes
Jan 16, 2024
|
Closing and re-opening to trigger CICD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20212 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
This PR fixes various test flakes / failures. Notably, it introduces a new check to test agent initialization that will wait for the bootstrap process to complete successfully before unblocking (which I suspect was causing a large number of flakes in tests globally).
It appears that there may have been a race condition in some of the peering state store logic due to the object not being cloned before mutation, which was flagged in tests. It doesn't appear to be a code path that would be encountered outside of our tests (which inserts partial data).
Overview of commits