-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of NET-5371 License checker pt2 into release/1.15.x #18494
Merged
hc-github-team-consul-core
merged 1 commit into
release/1.15.x
from
backport/license-checker-pt2/subtly-secure-raccoon
Aug 16, 2023
Merged
Backport of NET-5371 License checker pt2 into release/1.15.x #18494
hc-github-team-consul-core
merged 1 commit into
release/1.15.x
from
backport/license-checker-pt2/subtly-secure-raccoon
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbee7f8
to
24a2fd1
Compare
656090c
to
2eb6118
Compare
github-team-consul-core-pr-approver
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
This comment was marked as outdated.
This comment was marked as outdated.
* Update grep command to work on ubuntu * Run license checker when new commits are pushed to PR
2eb6118
to
4e629b1
Compare
nathancoleman
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches source PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/dependencies
PR specifically updates dependencies of project
type/ci
Relating to continuous integration (CI) tooling for testing or releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18491 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
I created a test PR (#18486) after merging this action originally in #18485 and realized that
grep
behaves differently inubuntu:latest
than it does in MacOS.This updates to use a format that works in Ubuntu and runs the action whenever new commits are pushed to a backport PR instead of just when it's initially opened.
Testing & Reproduction steps
Ran script in an Ubuntu docker container
Links
PR Checklist
Overview of commits