Pull virtual IPs for filter chains from discovery chains #17375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashi-derek
reviewed
May 16, 2023
27e38ec to
a9a5d97
Compare
hashi-derek
approved these changes
May 16, 2023
hashi-derek
reviewed
May 16, 2023
agent/xds/listeners.go
Outdated
| @@ -232,6 +232,15 @@ func (s *ResourceGenerator) listenersFromSnapshotConnectProxy(cfgSnap *proxycfg. | |||
| // We do not match on all endpoints here since it would lead to load balancing across | |||
| // all instances when any instance address is dialed. | |||
| for _, e := range endpoints { | |||
| if chain.Partition == e.Service.PartitionOrDefault() { | |||
There was a problem hiding this comment.
Ignore my last approval. In failover scenarios (where there may be zero endpoints), this would remove the chain's VIP from the config, right? So we should probably hoist the attachment of the chain outside of this loop.
There was a problem hiding this comment.
Do we still need this logic here if the code above is always attaching the VIPs?
There was a problem hiding this comment.
Not sure how that got left in, it's gone now
a9a5d97 to
f479922
Compare
f479922 to
99d5b0c
Compare
hashi-derek
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to previous work that adds logic in
xdsto pull virtual IPs from discovery chains - including both auto-assigned and manually set (such as cluster IPs via kubernetes).